Adds a toggle to allow shape files with no dbf #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoolsMcFly
force-pushed
the
feature/36-allow-no-dbf
branch
from
fa57fb1
to
09610f5
Compare
JoolsMcFly
commented
Nov 19, 2024
| @@ -326,8 +334,16 @@ public function getIndexFromDBFData(string $field, $value): int | |||
| */ | |||
| private function loadDBFHeader(): array | |||
| { | |||
| $DBFFile = fopen($this->getFilename('.dbf'), 'r'); | |||
| if (! self::supportsDbase()) { | |||
There was a problem hiding this comment.
I moved this block from loadHeaders so no matter where this method is called then we'll always check for support for dbase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This PR fixes #36 as it gives users the ability to process a shape file with no matching dbf file.
A call to $shp->setAllowNoDbf(true); does the trick.
I left open the PR targeting master because
3.1.xandmasterbranches are different enough (no psalm, use of ShapeFile enum etc) to have me change code from my first PR to make it work in3.1.x.Thanks for reviewing.