Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extension bcmath for 2nd factor authentication #415

Merged
merged 2 commits into from
Jun 30, 2023
Merged

add extension bcmath for 2nd factor authentication #415

merged 2 commits into from
Jun 30, 2023

Conversation

yankeguo
Copy link
Contributor

GMP or bcmath is required when second factor authentication is enabled.

yankeguo added 2 commits June 25, 2023 13:16
add extension bcmath for 2-factor authentication
add extension bcmath for 2-factor authentication
@yankeguo
Copy link
Contributor Author

For more details:

Enabling FIDO2 seems ok, but when login in with FIDO2, an error occured, says 'GMP or bcmath is required`.

@williamdes
Copy link
Member

Can you post some logs that shows that it's needed ?

@williamdes
Copy link
Member

Maybe this could be related to #416 and #417

@yankeguo
Copy link
Contributor Author

yankeguo commented Jun 30, 2023

@williamdes

截屏2023-06-30 11 13 38

截屏2023-06-30 10 53 04

I'm using phpmyadmin:5.2.1 from official docker repository and trying setting up FIDO2/Webauthn 2nd factor authentication with Safari Security Key and Apple iCloud Keychain.

Safari keep prompting for authentication while logging in, and never success, after I cancelled authentication, I found this error message.

I've tried building an image with bcmath installed, and things work again.

P.S.: If you want to reproduce this issue, please note that enabling FIDO2/Webauthn requires SSL to be properly configured.

@yankeguo
Copy link
Contributor Author

And I see no message in stdout/stderr

@yankeguo
Copy link
Contributor Author

#417 seems to be related, but I'm not sure that fix will restore GMP or bcmath extension

@williamdes
Copy link
Member

Okay, thank you for the input. I will have a second try at this

@williamdes williamdes added the bug label Jun 30, 2023
@williamdes williamdes merged commit 328b498 into phpmyadmin:master Jun 30, 2023
@williamdes
Copy link
Member

I pushed the ./update.sh version in 328b498

@williamdes williamdes self-assigned this Jun 30, 2023
williamdes added a commit that referenced this pull request Jun 30, 2023
Pull-request: #415

[ci skip]
@yankeguo yankeguo deleted the patch-1 branch June 30, 2023 09:30
@williamdes
Copy link
Member

Thank you for all the work, it is now deployed to the hub 🎉 : https://hub.docker.com/_/phpmyadmin/tags
Ref: docker-library/official-images#14960

@ibennetch
Copy link
Member

ibennetch commented Jul 6, 2023 via email

@williamdes
Copy link
Member

And I will push it to the other Docker repository when I have a chance.

Thank you

@yankeguo
Copy link
Contributor Author

yankeguo commented Jul 6, 2023

Thanks for all 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants