-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package metrics #283
Package metrics #283
Conversation
@UFOMelkor What is the status of this PR? We are really interested in your work here, so if I can somehow help you with finishing the implementation ping me. |
@tPl0ch Thank you for reminding me of this PR. There are two questions that need be answered:
Apart from this I hope everything is stable now. You could run an analysis of this branch against your code to check whether errors are thrown or not. |
@UFOMelkor hard work done 👍 Can you rebase your PR please ? How can we help you to finish ? |
1f9eeef
to
41c3a33
Compare
Perhaps you have some thoughts about this two questions …
|
About SAP, I'm documenting on it as I'm not totally aware of this. I'll give you my thoughts later.
About Trait handling, I think treating them like classes is a good option. Don't forget that horizontally extends doesn't exist in PHP and Traits are a kind of solution to that miss. This tend to understand traits usages as horizontal inheritance, like classes would do if PHP allow it.
… Le 26 oct. 2017 à 15:02, Oskar Pfeifer-Bley ***@***.***> a écrit :
Perhaps you have some thoughts about this two questions …
Do violations about the Stable Abstractions Principle make any sense (and if they do, which distance should be used as limit)?
How are traits handled related to packages? I tend to handle them like concrete classes.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
If #329 goes merge, please use |
any updates for this one? |
This PR adds package metrics to PhpMetrics.
Packages are recognized by @package/@subpackage annotations in the DocBlock of a class / interface / … or by the namespace (if not annotations are found).
Current status is
Any feedback would be appreciated 😊
Some images from a PhpMetrics analysis: