Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart is broken in group tab #433

Closed
Halleck45 opened this issue Jun 29, 2020 · 3 comments
Closed

Chart is broken in group tab #433

Halleck45 opened this issue Jun 29, 2020 · 3 comments
Labels

Comments

@Halleck45
Copy link
Collaborator

In 2.7.3, MI chart does not display due to #430

We need to revert this PR

@Halleck45 Halleck45 added the bug label Jun 29, 2020
@niconoe-
Copy link
Contributor

niconoe- commented Jun 29, 2020

This is mainly because the js variable "classes" is redefined, IMO. Why not declaring, and using, a different variable for layer groups?

EDIT: after a deeper analysis, the problem is bigger: For each layer group + general, all templates are reused, but without any variabilisation of unique stuff, so HTML ids are duplicated, such as js global variables and so...
We need to detect all duplicated that can't be and variable them using the group name or a group index to remove conflicts

@pattisahusiwa
Copy link
Contributor

@Halleck45, can you show a picture about the broken chart? or give more explanation about that. I can't reproduce the bug.

@Halleck45
Copy link
Collaborator Author

Halleck45 commented Jun 30, 2020

Hi @pattisahusiwa . When you click on the tab of specific group, the maintainability chart does not load due to JavaScript issue.

I think that #437 fixes the issue

Halleck45 added a commit that referenced this issue Jun 30, 2020
Fix issue with charts in groups - Closes #429, Closes #433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants