Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy host filtering #11

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Conversation

iteman
Copy link
Member

@iteman iteman commented Jul 13, 2016

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License BSD-2-Clause

This PR adds a feature that allows you to modify the hostname of the proxy URL at runtime.

To enable this feature, configure the proxy_host_filter_service element for the proxy URL as the following:

app/config/config.yml:

# ...

phpmentors_proxy_url_rewrite:
    proxy_urls:
        foo_bar:
            path: "!^.*!"
            proxy_url: "http://www.example.com/foo/bar"
            proxy_host_filter_service: app.proxy_host_filter

The class for proxy_host_filter_service must implement HostFilterInterface.

@iteman iteman added this to the 1.2.0 milestone Jul 13, 2016
@iteman iteman self-assigned this Jul 13, 2016
@iteman iteman changed the title Proxy hostname filtering Proxy host filtering Jul 13, 2016
@iteman iteman force-pushed the hostname-filtering branch from 4054d07 to c59cab1 Compare July 14, 2016 02:30
@iteman iteman merged commit c59cab1 into phpmentors-jp:master Jul 14, 2016
iteman added a commit that referenced this pull request Jul 14, 2016
This PR was merged into the 1.2-dev branch.

Discussion
----------

Proxy host filtering

| Q             | A
| ------------- | ---
| Branch?       | `master`
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | BSD-2-Clause

This PR adds a feature that allows you to modify the hostname of the proxy URL at runtime.

To enable this feature, configure the `proxy_host_filter_service` element for the proxy URL as the following:

`app/config/config.yml`:

```yaml

phpmentors_proxy_url_rewrite:
    proxy_urls:
        foo_bar:
            path: "!^.*!"
            proxy_url: "http://www.example.com/foo/bar"
            proxy_host_filter_service: app.proxy_host_filter
```

The class for `proxy_host_filter_service` must implement `HostFilterInterface`.

Commits
-------

c59cab1 add a feature that allows you to modify the hostname of the proxy URL at runtime
: Please enter a commit message to explain why this merge is necessary,
@iteman iteman deleted the hostname-filtering branch July 14, 2016 02:41
iteman added a commit that referenced this pull request Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant