change services.xml to use setFactory() instead of `setFactoryServi…

…ce() #5
phpmentors-jp · Jun 13, 2015 · 9567a2b · 9567a2b
1 parent 0e987dd
commit 9567a2b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/DependencyInjection/PHPMentorsProxyURLRewriteExtension.php b/src/DependencyInjection/PHPMentorsProxyURLRewriteExtension.php
@@ -18,6 +18,7 @@
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
+use Symfony\Component\DependencyInjection\DefinitionDecorator;
 
 class PHPMentorsProxyURLRewriteExtension extends Extension
 {
@@ -51,12 +52,7 @@ private function transformConfigToContainerParameters(array $config, ContainerBu
         if ($config['enabled']) {
             $index = 0;
             foreach ($config['proxy_urls'] as $path => $proxyUrl) {
-                $abstractDefinition = $container->getDefinition('phpmentors_proxy_url_rewrite.proxy_url');
-                $definition = new Definition();
-                $definition->setClass($abstractDefinition->getClass());
-                $definition->setFactoryService($abstractDefinition->getFactoryService());
-                $definition->setFactoryMethod($abstractDefinition->getFactoryMethod());
-                $definition->setAbstract(false);
+                $definition = new DefinitionDecorator('phpmentors_proxy_url_rewrite.proxy_url');
                 $definition->setArguments(array($path, $proxyUrl));
 
                 $serviceId = 'phpmentors_proxy_url_rewrite.proxy_url'.$index;

diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml
@@ -21,7 +21,9 @@
       </call>
     </service>
     <service id="phpmentors_proxy_url_rewrite.proxy_asset_extension" class="%phpmentors_proxy_url_rewrite.proxy_asset_extension.class%" public="false"/>
-    <service id="phpmentors_proxy_url_rewrite.proxy_url" class="%phpmentors_proxy_url_rewrite.proxy_url.class%" factory-service="phpmentors_proxy_url_rewrite.proxy_url_factory" factory-method="create" abstract="true"/>
+    <service id="phpmentors_proxy_url_rewrite.proxy_url" class="%phpmentors_proxy_url_rewrite.proxy_url.class%" abstract="true">
+      <factory service="phpmentors_proxy_url_rewrite.proxy_url_factory" method="create"/>
+    </service>
     <service id="phpmentors_proxy_url_rewrite.proxy_url_collection" class="%phpmentors_proxy_url_rewrite.proxy_url_collection.class%"/>
     <service id="phpmentors_proxy_url_rewrite.proxy_url_factory" class="%phpmentors_proxy_url_rewrite.proxy_url_factory.class%"/>
     <service id="phpmentors_proxy_url_rewrite.proxy_url_rewrite_listener" class="%phpmentors_proxy_url_rewrite.proxy_url_rewrite_listener.class%">