-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of html-tags in ToU and PP #68
Conversation
That change makes sense to me, it looks good. |
For future reference, I asked about the v4 thing in the Symfony chatroom, here were some of the answers:
|
Yes, that is my plan. I will revert the composer.lock change here.
But we need to look at this later on.
Am 9. November 2020 14:39:41 MEZ schrieb battye <[email protected]>:
…
@battye commented on this pull request.
> },
{
"name": "symfony/debug",
- "version": "v3.4.36",
+ "version": "v4.4.15",
@Crizz0 maybe the composer.lock change can be removed from the PR so
that only the `LangKeyValidator.php` code change flows through?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#68 (comment)
|
Mhm, like this is at the moment, the patch will break validation for phpBB 3.2.11 language packages. So i added a if-sentence for this version to avoid this. |
Fixes #67