Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of html-tags in ToU and PP #68

Merged
merged 6 commits into from
Nov 10, 2020
Merged

Conversation

Crizz0
Copy link
Member

@Crizz0 Crizz0 commented Oct 27, 2020

Fixes #67

@Crizz0 Crizz0 added this to the 1.5.3 milestone Oct 27, 2020
@Crizz0 Crizz0 changed the title Issue/67 Fixe handling of html-tags in ToU and PP Oct 27, 2020
@Crizz0 Crizz0 changed the title Fixe handling of html-tags in ToU and PP Fix handling of html-tags in ToU and PP Oct 27, 2020
@battye
Copy link
Member

battye commented Nov 4, 2020

That change makes sense to me, it looks good.

composer.lock Outdated Show resolved Hide resolved
@battye
Copy link
Member

battye commented Nov 9, 2020

For future reference, I asked about the v4 thing in the Symfony chatroom, here were some of the answers:

In my Symfony 4.4 project some packages also got updated to 5.x because they aren’t limited explicitly

if you want to limit symfony/debug to <4 you also need to add: "symfony/debug": "~3.0"

or add extra: {symfony: {require: 3.4.* }} into your composer.json file

@Crizz0
Copy link
Member Author

Crizz0 commented Nov 9, 2020 via email

@Crizz0
Copy link
Member Author

Crizz0 commented Nov 10, 2020

Mhm, like this is at the moment, the patch will break validation for phpBB 3.2.11 language packages.

So i added a if-sentence for this version to avoid this.

@Crizz0 Crizz0 requested review from battye, marc1706 and DavidIQ and removed request for marc1706 November 10, 2020 18:21
@DavidIQ DavidIQ merged commit f4c5e09 into phpbb:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with phpBB 3.3.2 and PRIVACY_POLICY and TERMS_OF_USE
5 participants