Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine module auth #89

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Refine module auth #89

merged 5 commits into from
Nov 11, 2024

Conversation

iMattPro
Copy link
Contributor

@iMattPro iMattPro commented Nov 6, 2024

The test fix should eliminate the random test failings

@iMattPro iMattPro requested a review from rxu November 6, 2024 16:33
@iMattPro
Copy link
Contributor Author

iMattPro commented Nov 6, 2024

@paul999 What are your thoughts on the proposed changes to the two migration files? In particular, what would happen if we uncommented the erroneous line in the first migration file?

@paul999
Copy link

paul999 commented Nov 8, 2024

I would say if you umcomment, the other migration is technically direclty effectivly installed for new installs.
However, to keep in line with not changing migrations, I would say leave it out, as you already need to fix old installs. And for new installs it doesn't matter the if it is directly set correctly, or via the second migration.

@iMattPro
Copy link
Contributor Author

iMattPro commented Nov 8, 2024

I would say if you umcomment, the other migration is technically direclty effectivly installed for new installs. However, to keep in line with not changing migrations, I would say leave it out, as you already need to fix old installs. And for new installs it doesn't matter the if it is directly set correctly, or via the second migration.

Okay, I’ll leave it in but commented out. I’m doing this to prevent anyone who might copy this code for themselves from making the same mistake we did with adding modules. We forgot that line of code.

@paul999
Copy link

paul999 commented Nov 8, 2024

Yep, sounds good. Please mention it when submitting, so we don't forget we discussed it already.

@iMattPro iMattPro merged commit 9fe40af into phpbb-extensions:main Nov 11, 2024
32 checks passed
@iMattPro iMattPro deleted the Fixins branch November 11, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants