-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine module auth #89
Conversation
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
@paul999 What are your thoughts on the proposed changes to the two migration files? In particular, what would happen if we uncommented the erroneous line in the first migration file? |
I would say if you umcomment, the other migration is technically direclty effectivly installed for new installs. |
Okay, I’ll leave it in but commented out. I’m doing this to prevent anyone who might copy this code for themselves from making the same mistake we did with adding modules. We forgot that line of code. |
Yep, sounds good. Please mention it when submitting, so we don't forget we discussed it already. |
Signed-off-by: Matt Friedman <[email protected]>
The test fix should eliminate the random test failings