Add InlineValue objects to generated LSP #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assume all the PHP code is generated? |
|
Ofcourse. But I have not been able to try it in the project yet. |
|
And for that matter, also a generate + check for no git changes test. |
|
it should be fine, we run PHPStan on it and there are some smoke tests. tbh I'm constantly amazed this works as well as it does 😆 |
|
would be good to run some B/C checks to the pipeline -- however when upgrading the TS code occasionally the constructor argument order can change, and not really sure how to prevent that easily. In such cases I just sync all the phpactor code to the new version and try and use named parameters 🙄 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.