Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extendable compiler context #972

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Extendable compiler context #972

merged 2 commits into from
Apr 12, 2024

Conversation

jaapio
Copy link
Member

@jaapio jaapio commented Apr 12, 2024

The Compiler context is a very important class in our compiler, however
extending projects may want to extend the information caried around with the context
to add extra information for specific use cases in custom compiler passes.

To make this possible I introduced a new interface to be able to wrap the compilercontext
and extend the functionality. Changing the interfaces would be a backward compatibility break
so we need to introduce this step by step.

refs #971

@jaapio jaapio requested a review from linawolf April 12, 2024 11:38
@jaapio jaapio force-pushed the fix/extendable-compiler-context branch 3 times, most recently from 404c788 to 76aaa48 Compare April 12, 2024 14:07
jaapio added 2 commits April 12, 2024 20:49
The Compiler context is a very important class in our compiler, however
extending projects may want to extend the information caried around with the context
to add extra information for specific use cases in custom compiler passes.

To make this possible I introduced a new interface to be able to wrap the compilercontext
and extend the functionality. Changing the interfaces would be a backward compatibility break
so we need to introduce this step by step.
@jaapio jaapio force-pushed the fix/extendable-compiler-context branch from 76aaa48 to c05322d Compare April 12, 2024 18:49
@jaapio jaapio merged commit 324b04c into main Apr 12, 2024
40 checks passed
@jaapio jaapio deleted the fix/extendable-compiler-context branch April 12, 2024 19:17
@jaapio jaapio removed the request for review from linawolf April 12, 2024 19:17
@phpdoc-bot
Copy link

💔 All backports failed

Status Branch Result
1.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 972

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants