Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Correct Menu levels in global menu tree #805

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

linawolf
Copy link
Contributor

@linawolf linawolf commented Jan 6, 2024

Resolves #803

@wouterj does this resolve your issue?

@linawolf linawolf self-assigned this Jan 6, 2024
@linawolf linawolf requested a review from jaapio January 6, 2024 08:34
@linawolf linawolf force-pushed the bugfix/level-off branch 2 times, most recently from 0db494c to 5165cfd Compare January 6, 2024 08:39
@wouterj
Copy link
Contributor

wouterj commented Jan 6, 2024

Thanks for trying to tackle the issue.

This fixes the case for level 1, but it seems like all sub nodes are still one up:

<div class="menu-wrapper menu-size-md">
    <ul>
        <li class="toctree-l1">
            <a href="/getting_started/index.html#getting-started">Getting Started</a>
            <ul>
                <li class="toctree-l3">
                    <a href="/setup.html#installing-setting-up-the-symfony-framework">Installing &amp; Setting up the Symfony Framework</a>
                    <ul>
                        <li class="toctree-l4">
                            <a href="/setup/bundles.html#upgrading-a-third-party-bundle-for-a-major-symfony-version">Upgrading a Third-Party Bundle for a Major Symfony Version</a>
                        </li>
                        <li class="toctree-l4">
                            <a href="/setup/file_permissions.html#setting-up-or-fixing-file-permissions">Setting up or Fixing File Permissions</a>
                        </li>
                        <!-- ... -->

@linawolf linawolf marked this pull request as draft January 8, 2024 11:33
@linawolf
Copy link
Contributor Author

linawolf commented Jan 8, 2024

Thanks @wouterj, I will add tests for that

@linawolf linawolf marked this pull request as ready for review January 12, 2024 16:48
@linawolf
Copy link
Contributor Author

@wouterj please have another look

@jaapio jaapio merged commit d545130 into main Jan 19, 2024
38 checks passed
@jaapio jaapio deleted the bugfix/level-off branch January 19, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render menu has off by 1 issue
3 participants