Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!![TASK] Warn only once when a reference cannot be resolved #797

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

linawolf
Copy link
Contributor

This is a breaking change to those who have implemented a custom ReferenceResolver.

@linawolf linawolf requested a review from jaapio December 31, 2023 10:56
@linawolf linawolf self-assigned this Dec 31, 2023
Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the messages nullable? was this an attempt to not make this a breaking change?

@linawolf linawolf force-pushed the task/improve-link-reporting branch from 87548a1 to 324e6cc Compare January 1, 2024 07:55
@linawolf linawolf requested a review from jaapio January 1, 2024 07:56
This is a breaking change to those who have implemented a custom ReferenceResolver.
@jaapio jaapio force-pushed the task/improve-link-reporting branch from 324e6cc to d977694 Compare January 2, 2024 19:38
@jaapio jaapio enabled auto-merge January 2, 2024 19:38
@jaapio jaapio merged commit adde014 into main Jan 2, 2024
38 checks passed
@jaapio jaapio deleted the task/improve-link-reporting branch January 2, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants