Fix using < or > in a reference name #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
force-pushed
the
html-tags-in-reference
branch
2 times, most recently
from
7d12189 to
cc2e28c
Compare
linawolf
requested changes
Dec 16, 2023
packages/guides-restructured-text/src/RestructuredText/Parser/InlineLexer.php
Outdated
Show resolved
Hide resolved
wouterj
force-pushed
the
html-tags-in-reference
branch
2 times, most recently
from
30fa949 to
dc06ee1
Compare
|
You are correct, this was too fragile. I've now rewritten the code to delegate parsing the embedded URI to the rules/roles that need it and removing it from the global inline lexer. This is the safest and shouldn't break anything, given embedded URIs do not exist on their own. |
|
I like it, it will also make things easier for us in the php-domain text-roles |
linawolf
approved these changes
Dec 17, 2023
wouterj
force-pushed
the
html-tags-in-reference
branch
from
dc06ee1 to
9440e98
Compare
jaapio
approved these changes
Dec 18, 2023
These characters are valid and only the last `<...>` must be treated as the embeded URL. This stops using the inline lexer inside references, reSt doesn't allow nested inline nodes and the only thing required is getting the embeded URL (if there is any).
jaapio
force-pushed
the
html-tags-in-reference
branch
from
9440e98 to
c0e4b1b
Compare
linawolf
added a commit
to TYPO3-Documentation/guides-php-domain
that referenced
this pull request
Dec 20, 2023
With phpDocumentor/guides#761 the textroles where changed to not rely on the lexer anymore. This makes it necessary to switch to a regex.
linawolf
added a commit
to TYPO3-Documentation/guides-php-domain
that referenced
this pull request
Dec 20, 2023
With phpDocumentor/guides#761 the textroles where changed to not rely on the lexer anymore. This makes it necessary to switch to a regex.
linawolf
added a commit
to TYPO3-Documentation/guides-php-domain
that referenced
this pull request
Dec 21, 2023
With phpDocumentor/guides#761 the textroles where changed to not rely on the lexer anymore. This makes it necessary to switch to a regex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These characters are valid and only the last
<...>must be treated as the embedded URL.This PR removes using the inline lexer inside references, reSt doesn't allow nested inline nodes and the only thing required is getting the embedded URL (if there is any). This reduces a lot of complexity