[TASK] Replace Integration tests with xmllint #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaapio any idea why tools/xmllint.sh is not found in the github actions? |
|
You need to add a the checkout step like the other. Jobs have. |
linawolf
force-pushed
the
task/improve-xml-lint
branch
from
45073e9 to
dcc6071
Compare
jaapio
approved these changes
Nov 20, 2023
Linting xml files is not really the responsibility of integration tests. As a plus using xmllint works on all guides.xml including those in our doc directly and the basic one
jaapio
force-pushed
the
task/improve-xml-lint
branch
from
dcc6071 to
8319bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting xml files is not really the responsibility of integration tests.
As a plus using xmllint works on all guides.xml including those in our doc directly and the basic one