Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix parsing and rendering of code-block with line numbers #685

Merged
merged 1 commit into from
Nov 18, 2023
Merged

[BUGFIX] Fix parsing and rendering of code-block with line numbers #685

merged 1 commit into from
Nov 18, 2023

Conversation

linawolf
Copy link
Contributor

  • There was an error triggered by using lineno-start option.
  • the data-start attribute was output without quotes
  • integration tests were missing

resolves #684

@linawolf
[BUGFIX] Fix parsing and rendering of code-block with line numbers
c5b6d5b 
- There was an error triggered by using `lineno-start` option.
- the data-start attribute was output without quotes
- integration tests were missing
@linawolf linawolf mentioned this pull request Nov 18, 2023
Closed
@linawolf linawolf merged commit 6504690 into main Nov 18, 2023
25 checks passed
@linawolf linawolf deleted the bugfix/lineno branch November 18, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brotkrueml brotkrueml brotkrueml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using lineno-start on code-block directive throws error
2 participants
@linawolf @brotkrueml