[TASK] Validate guides.xml files against scheme #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
reviewed
Nov 9, 2023
| @@ -2,12 +2,13 @@ | |||
| <xsd:schema | |||
| targetNamespace="https://www.phpdoc.org/guides" | |||
| xmlns:xsd="http://www.w3.org/2001/XMLSchema" | |||
| xmlns="https://www.phpdoc.org/guides" | |||
There was a problem hiding this comment.
First we should make it work?
There was a problem hiding this comment.
I wouldn't publish the XSD on an uri (but instead reference a local file like done in the examples in this PR). You need proper version management when publishing the XSD's, something you get from free when you recommend people to use the XSD installed in their vendor directory.
(XML namespaces being a "uri" has no relation to the web)
And fix XML scheme so that our configurations can be validated
linawolf
force-pushed
the
task/validate-xml
branch
from
8c53a4f to
a1ddf8e
Compare
|
@jaapio all tests are green now, please review |
jaapio
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.