!!![TASK] Remove all services from render context #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
task/serviceless-context
branch
from
60952ef to
6ec95ae
Compare
linawolf
reviewed
Oct 31, 2023
| @@ -27,6 +27,6 @@ public function getContext(): RenderContext | |||
|
|
|||
| public function getFileDestination(): string | |||
| { | |||
| return $this->renderContext->getCurrentFileDestination(); | |||
| return $this->renderContext->getDestinationPath() . '/' . $this->renderContext->getCurrentFileName() . '.' . $this->renderContext->getOutputFormat(); | |||
linawolf
approved these changes
Oct 31, 2023
The render context should be a service less object only containing the context of the current rendered project/document. This reduces the ways we are generating urls and makes the creation of the object less complex.
jaapio
force-pushed
the
task/serviceless-context
branch
from
6ec95ae to
98eca7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The render context should be a service less object only containing the context of the current rendered project/document. This reduces the ways we are generating urls and makes the creation of the object less complex.