[FIX] use canonicalUrl to fetch images #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a test for that would be nice? |
|
I added a test and also tried it out with the powermail guide: works fine and code looks good |
linawolf
force-pushed
the
fix/relative-image-urls
branch
from
9a8fbdd to
5f0dfc3
Compare
linawolf
approved these changes
Oct 11, 2024
|
Thanks for adding the test |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
phpdoc-bot
added a commit
that referenced
this pull request
Oct 11, 2024
[1.x] Merge pull request #1133 from phpDocumentor/fix/relative-image-urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will solve the situations containing relative urls.