Merge pull request #626 from phpDocumentor/fix/absolute_image_url

Fix: allow absolute image urls

packages/guides/resources/template/html/body/image.html.twig

@@ -1,5 +1,5 @@
 <img
-    src="{{ asset(node.value) }}"
+    src="{%- if node.value is external_target -%} {{ node.value }} {%- else -%} {{ asset(node.value) }} {%- endif -%}"
     {% if node.hasOption('width') %}width="{{ node.option('width') }}"{% endif%}
     {% if node.hasOption('height') %}height="{{ node.option('height') }}"{% endif%}
     {% if node.hasOption('align') %}align="{{ node.option('align') }}"{% endif%}

packages/guides/src/Twig/AssetsExtension.php

@@ -14,6 +14,8 @@
 namespace phpDocumentor\Guides\Twig;
 
 use League\Flysystem\Exception;
+use League\Uri\Uri;
+use League\Uri\UriInfo;
 use LogicException;
 use phpDocumentor\Guides\Meta\InternalTarget;
 use phpDocumentor\Guides\Meta\Target;
@@ -26,6 +28,7 @@
 use phpDocumentor\Guides\UrlGeneratorInterface;
 use Psr\Log\LoggerInterface;
 use RuntimeException;
+use Stringable;
 use Twig\Extension\AbstractExtension;
 use Twig\TwigFunction;
 use Twig\TwigTest;
@@ -66,6 +69,10 @@ public function getTests(): array
                 /** @param mixed $value */
                 static fn (mixed $value): bool => $value instanceof Node,
             ),
+            new TwigTest(
+                'external_target',
+                static fn (string|Stringable $value): bool => UriInfo::isAbsolute(Uri::createFromString($value)),
+            ),
         ];
     }
 

packages/guides/src/UrlGenerator.php

@@ -33,6 +33,10 @@ final class UrlGenerator implements UrlGeneratorInterface
     public function absoluteUrl(string $basePath, string $url): string
     {
         $uri = UriFactory::createUri($url);
+        if (UriInfo::isAbsolute($uri)) {
+            return $url;
+        }
+
         if (UriInfo::isAbsolutePath($uri)) {
             return $url;
         }

tests/Functional/tests/image-fullurl/image-fullurl.html

@@ -0,0 +1,2 @@
+<p>Test</p>
+<img src="https://img.shields.io/github/contributors/ORG/REPO" />

tests/Functional/tests/image-fullurl/image-fullurl.rst

@@ -0,0 +1,3 @@
+Test
+
+.. image:: https://img.shields.io/github/contributors/ORG/REPO