-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse Group Use Statements #64
Parse Group Use Statements #64
Conversation
- Updated namespace parser to handle grouped namespaces Signed-off-by: RJ Garcia <[email protected]>
5703f61
to
51761af
Compare
Thanks, this looks good. I will have a look later this week to see if we can merge and release this. |
@@ -14,11 +14,14 @@ | |||
|
|||
// Added imports on purpose as mock for the unit tests, please do not remove. | |||
use \ReflectionClass; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this line to come right after the PHPUnit grouping? That way, the parsing rules will have a line after the grouping to process. I'd like to see how the test goes after that change.
I checked the change requested by @ashnazg. This is merged to master now. |
@jaapio No rush, just curious when we can expect a release. |
Think that will be done this week. My day is almost ending, and I have no clue yet when I'm able to finish this merge. There are a number of code style checks failing. That I need to fix before the release |
Ok, time to stop for to day. Thanks @ragboyjr for adding this feature. |
dude, awesome! |
Signed-off-by: RJ Garcia [email protected]