Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for "int<min,max>", "negative-int" and "numeric" #139

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

voku
Copy link
Contributor

@voku voku commented Nov 24, 2021

src/Types/Numeric_.php Outdated Show resolved Hide resolved
@voku
Copy link
Contributor Author

voku commented Nov 27, 2021

Failing test seems not related to this changes.

voku added a commit to voku/Simple-PHP-Code-Parser that referenced this pull request Nov 29, 2021
@jaapio
Copy link
Member

jaapio commented Dec 7, 2021

A first thought after a quick review:

Although I like the support for the psalm types, I begin to worry about the amount of code paths we have in the type resolver.

This is not something we should change right away, but I think before we start adding more types, I (we) should start thinking about a more robust and sustainable parser. Right now we are mixing the object creation and parsing which isn't nice. But more important, there are some less obvious bugs reported, easier to read code will help us to detect those.

@jaapio
Copy link
Member

jaapio commented Jan 4, 2022

Thanks for these additions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants