-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list pseudo-type #136
Add list pseudo-type #136
Conversation
Note: I didn't try to actually run the tests. It's very unclear to me how I'm supposed to do that since phpunit is missing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution!
Regarding the unittests. This library is a hard one to test. We had issues in the past where phpunit was testing the wrong classes because of the way autoloading works in php. As this lib is a dependency of phpunit dependencies.
The easiest way to run the tests at your local machine is using docker. (which is part of our Makefile)
make pre-commit-test
docker run -it --rm -v${PWD}:/opt/project -w /opt/project php:7.2 tools/phpunit
If you don't have docker installed you can also use https://phar.io/ to install phpunit.
phive install
tools/phpunit
Let me know when you have any questions.
@jaapio Done. Tests are now passing locally. Try to trigger the pipeline please. |
Just a small code style fix that need to be applied. I will handle that. |
@jaapio Thanks! Any estimate when this can be released? |
This month, as we are preparing for php 8.1 |
Closes #134