Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list pseudo-type #136

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Add list pseudo-type #136

merged 1 commit into from
Oct 30, 2021

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Oct 29, 2021

Closes #134

@enumag
Copy link
Contributor Author

enumag commented Oct 29, 2021

Note: I didn't try to actually run the tests. It's very unclear to me how I'm supposed to do that since phpunit is missing in require-dev and therefore not installed at all. And since the tests are not being executed here either I've no idea if they're passing.

Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

Regarding the unittests. This library is a hard one to test. We had issues in the past where phpunit was testing the wrong classes because of the way autoloading works in php. As this lib is a dependency of phpunit dependencies.

The easiest way to run the tests at your local machine is using docker. (which is part of our Makefile)
make pre-commit-test

docker run -it --rm -v${PWD}:/opt/project -w /opt/project php:7.2 tools/phpunit

If you don't have docker installed you can also use https://phar.io/ to install phpunit.

phive install
tools/phpunit

Let me know when you have any questions.

src/PseudoTypes/List_.php Outdated Show resolved Hide resolved
src/PseudoTypes/List_.php Show resolved Hide resolved
@enumag
Copy link
Contributor Author

enumag commented Oct 30, 2021

@jaapio Done. Tests are now passing locally. Try to trigger the pipeline please.

@jaapio
Copy link
Member

jaapio commented Oct 30, 2021

Just a small code style fix that need to be applied. I will handle that.
Thanks for this fix!

@jaapio jaapio merged commit 528f51b into phpDocumentor:1.x Oct 30, 2021
@enumag
Copy link
Contributor Author

enumag commented Nov 1, 2021

@jaapio Thanks! Any estimate when this can be released?

@jaapio
Copy link
Member

jaapio commented Nov 1, 2021

This month, as we are preparing for php 8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for list<Foo> type
2 participants