Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include composer.lock in distribution #118

Merged
merged 1 commit into from
Jul 24, 2021
Merged

Do not include composer.lock in distribution #118

merged 1 commit into from
Jul 24, 2021

Conversation

kubawerlos
Copy link
Contributor

The composer.lock entry is clearly missing export-ignore.

@jaapio
Copy link
Member

jaapio commented Jul 24, 2021

Although it doesn't harm to have this in the exclude export, it doesn't harm either to have it in the export.
Composer will look for a lock-file at project level and will not use the lock file of dependencies.

Thanks for this minor fix.

@jaapio jaapio merged commit 803c662 into phpDocumentor:1.x Jul 24, 2021
@kubawerlos
Copy link
Contributor Author

Although it doesn't harm to have this in the exclude export, it doesn't harm either to have it in the export.

Exactly the same can be said about any other line in .gitattributes 😉

@kubawerlos kubawerlos deleted the do_not_include_composer_lock_in_dist branch July 28, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants