Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix array-offset via "isset"-call #104

Merged
merged 1 commit into from
Sep 17, 2021
Merged

fix array-offset via "isset"-call #104

merged 1 commit into from
Sep 17, 2021

Conversation

voku
Copy link
Contributor

@voku voku commented May 22, 2020 •
edited
Loading

I saw that error in isPartialStructuralElementName while parsing all /vendor/* stuff for testing reasons. And I found the second isset($token[0]) call only because I was searching for "[0]" in the code.

This change is Reviewable

@voku
Copy link
Contributor Author

voku commented May 22, 2020

some tests failed with http error 500 from github :-/

@jaapio
Copy link
Member

jaapio commented Jun 19, 2020

Thanks for your contribution.
Could you please add a test that reproduces the issue you had so we make sure that we don't break this in te future.

@jaapio jaapio changed the base branch from master to 1.x June 19, 2020 19:59
@jaapio
Copy link
Member

jaapio commented Jul 24, 2021

@voku sorry that I took so long to come back to you. Could you please rebase this PR?

@voku voku force-pushed the fix_array_offset branch from b8982be to 25ab1c4 Compare August 21, 2021 23:01
@jaapio jaapio merged commit a36a6cc into phpDocumentor:1.x Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapio jaapio jaapio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voku @jaapio