Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing context argument in snippets for resolving partial names #1

Merged
merged 1 commit into from
Jun 12, 2015

Conversation

stof
Copy link
Contributor

@stof stof commented Jun 12, 2015

This argument is needed to be able to resolve partial names, as explained in the documentation around these snippets.
I currently wrote the snippet as if the $context was already defined by one of the snippets of the previous section. I think that the current wording makes it clear (the title of this section is Using the context for instance). An alternative would be to add a reminder about it:

$context = // ...
$typeResolver = new \phpDocumentor\Reflection\TypeResolver();
$type = $typeResolver->resolve('Types\Context', $context);

I also updated the link to the Composer website to use HTTPS (the site redirects to HTTPS anyway when accessing it with HTTP)

@mvriel
Copy link
Member

mvriel commented Jun 12, 2015

Thanks! It would seem I had indeed forgot to add those in the README

mvriel added a commit that referenced this pull request Jun 12, 2015
Add the missing context argument in snippets for resolving partial names
@mvriel mvriel merged commit 600cea7 into phpDocumentor:master Jun 12, 2015
@stof stof deleted the patch-1 branch June 12, 2015 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants