Update footer.inc #702
Update footer.inc #702
Conversation
manual View Source is a 404 error page.
|
link to the manual XML file, will be a Better idea. |
|
I'm not sure how this fixes the problem. Could you explain? |
|
visit this url https://www.php.net/manual/en/function.date.php and click view source. will be 404
Use this patch will close this function on the manual page.
…---Original---
From: "Kamil ***@***.***>
Date: Sun, Sep 18, 2022 22:02 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [php/web-php] Update footer.inc (PR #702)
I'm not sure how this fixes the problem. Could you explain?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Did you by any chance mean to use |
|
Do you mean you inserted a ternary operator there somewhere? I cannot see it in this PR. |
|
We should either remove that link completely, or just use the same URL as for the "Submit a pull request" link. |
|
Well, then someone must be wrong; either you or me. @cmb69 Can you see a ternary operator in the code? |
|
The patch as is makes no sense; if the 5 first bytes equal "manual", the variable is not empty. |
|
The original meaning is that if there is not setting baseurl, the view source will not be displayed , set baseurl the view source will be displayed so that you can view the source code. The part I added is that this function is in the manual part, the view source code 404, so I turn off when viewing the manual. If you have a better plan, of course, you can also propose changes and improvements according to your ideas.
…---Original---
From: "Kamil ***@***.***>
Date: Tue, Sep 20, 2022 23:42 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [php/web-php] Update footer.inc (PR #702)
Do you mean you inserted a ternary operator there somewhere? I cannot see it in this PR.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I want this expression to mean that if base_url is empty, the view will not be displayed, or if it starts with "manual", it will not be displayed too. i think you can test that part localhost.
…---Original---
From: "Christoph M. ***@***.***>
Date: Tue, Sep 20, 2022 23:58 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [php/web-php] Update footer.inc (PR #702)
The patch as is makes no sense; if the 5 first bytes equal "manual", the variable is not empty.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
sorry i think i push a error patch. it's my flaw. i confused it with a ternary operator.
i will update code.
…---Original---
From: "Christoph M. ***@***.***>
Date: Tue, Sep 20, 2022 23:58 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [php/web-php] Update footer.inc (PR #702)
The patch as is makes no sense; if the 5 first bytes equal "manual", the variable is not empty.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
changed
|
i update the code for my idea. @kamil-tekiela |
|
@cmb69 @mj @kamil-tekiela , i change the code, please help me, review and approval. think you. |
|
Thanks. The code makes more sense now, but still isn't something that we would merge. However, I think cmb69 might be right that the solution you are proposing isn't the ideal solution. |
I have overlooked that "view source" as is makes sense for those who want to work on web-php (not doc-en). As such, @rongzedong's suggestion makes sense now, although that code should be refactored. |
|
We could have an |
|
yes. I also think it is a better solution if I can access the corresponding version of doc xml source, my solution is just a transitional solution to solve the 404 problem.
…---Original---
From: "Kamil ***@***.***>
Date: Wed, Sep 21, 2022 21:05 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [php/web-php] Update footer.inc (PR #702)
We could have an else condition too. It would link to doc-en.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@cmb69 i find this,: strncmp() is 20% faster than substr() :D |
Yes, I know ( |
|
Looks like this has been overlooked. I've merged it now. Thank you! |
manual View Source is a 404 error page.