-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve homepage hero design #459
Conversation
I just set up a temporary mirror. The forced push was just a rebase with master. |
I like this and I am in favour of it. I would even put the aside permanently at the bottom. I would also change the "upgrading" text to "migration guide" |
The <strong> tag currently defaults to a 700 font-weight, which causes weird looking results on Windows as the higher weight included for the Fira Sans font is 500.
Co-authored-by: Kamil Tekiela <[email protected]>
Initially I intended to change this text as well, but later decided to left it out to reduce the number of changes in this patch. Should we create an issue for this? Thanks for reviewing. |
Center align the hero versions on mobile screens. Additionally, increases the margin between versions to prevent users from mistapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvement. Thank you!
The only concern I have is prominently linking to https://www.php.net/manual/en/getting-started.php. Especially the "simple tutorial" is in urgent need of some TLC. On the other hand, this may help to get that part improved.
So, if there are no objections, I'll merge this early next week.
I'm happy to hear you liked it @cmb69! Another option for the primary action is the latest release page. Here's how it would look like: We could create an issue for polishing the simple tutorial and link when it's done. |
Linking to the latest release page is also okayish for me, although that is not quite what I'd expect on "Get Started". |
Changes the primary action to "What's new in 8.1", linking to the release page. The Getting Started section in the manual needs some care before being actively promoted. Co-authored-by: Christoph M. Becker <[email protected]>
Oh sure, the text would also be updated to reflect the link. The button is now "What's new in 8.1" and links to the release page. I updated the live preview (may need a force refresh), and there is a screenshot in my previous comment as well. Looks great to me! |
Awesome, thanks everyone! |
view this proposal live here: https://php.lhsazevedo.dev/Intro
The PHP webpage has received some design proposals in the past [1,2]. I think they didn't get traction or support from the community because they were drastic changes and walked away from the current PHP branding style.
But we had a recent case of a successful design improvement: the PHP 8.0 (and 8.1) release page.
The new release page proposed [3] by JetBrains employees was accepted and very well received by the community [4-7].
Inspired by the new release page, and following the same design principles, I would like to propose small tweaks to the home page hero section. Note that this is not a complete redesign, the current style is respected and improved upon.
Proposal
If accepted, this PR will adjust the home page hero section design to accomplish the following objectives:
Some notable changes are:
Desktop overview
Mobile overview
At the moment. the actions are:
We can change those actions to better reflect user needs and the PHP team intentions.
Background
Back in Nov 2021, I created an issue proposing some adjustments to the design of the homepage hero section.
Preview
View this proposal live here: https://php.lhsazevedo.dev/Desktop:
Mobile:
[1] #332
[2] https://externals.io/message/104088
[3] https://externals.io/message/112026
[4] https://externals.io/message/112026#112073
[5] #350 (comment)
[6] https://twitter.com/official_php/status/1331989622025580550
[7] https://twitter.com/official_php/status/1463949488016564230