Deprecate SplFixedArray::__wakeup() #9704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
approved these changes
Oct 18, 2022
|
If you think an RFC is necessary, feel free to add this to https://wiki.php.net/rfc/deprecations_php_8_3. |
|
@TysonAndre could you rebase this as this has been accepted via an RFC now? |
phpGH-9354 added the `__serialize` and `__unserialize` method, so unserialize() and other unserializers will call `__unserialize` instead of `__wakeup` for SplFixedArray and userland subclasses. This targets php 8.3 because we've already released betas and release candidates for php 8.2.
TysonAndre
force-pushed
the
deprecate-SplFixedArray-wakeup
branch
from
ac679ae to
684b87a
Compare
Girgias
approved these changes
Aug 8, 2024
Girgias
added a commit
to Girgias/php-src
that referenced
this pull request
Aug 8, 2024
Girgias
added a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: Tim Düsterhus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-9354 added the
__serializeand__unserializemethod, so unserialize() and other unserializers will call__unserializeinstead of__wakeupfor SplFixedArray and userland subclasses.This targets php 8.3 because we've already released betas and release candidates for php 8.2.
This was brought up in review comments for php 8.2: #9354 (comment)