Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpine testing to CI #8621

Closed
wants to merge 9 commits into from
Closed

Add Alpine testing to CI #8621

wants to merge 9 commits into from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented May 24, 2022

test Alpine/musl libc in CI

needs #9139, #9140, #9149

old PR: #5933

@mvorisek
Copy link
Contributor Author

@alexdowad any idea how to fix the iconv test?

@cmb69 any idea about the missing enchant dict and posix test failures?

@alexdowad
Copy link
Contributor

@alexdowad any idea how to fix the iconv test?

Dear @mvorisek, I don't mind having a look at it. Could you share a link to the output of the failing test?

Do you have anything like a Dockerfile which I could use to run your tests locally?

@mvorisek
Copy link
Contributor Author

@alexdowad any idea how to fix the iconv test?

Dear @mvorisek, I don't mind having a look at it. Could you share a link to the output of the failing test?

Do you have anything like a Dockerfile which I could use to run your tests locally?

thanks for a quick reaction, the test failures are here: https://github.com/php/php-src/runs/6609199312?check_suite_focus=true#step:10:4351

I do not have a DockerFile directly, but you should be able to replicate the failures using alpine:3.15 image,

packages and configure command

@cmb69
Copy link
Member

cmb69 commented May 26, 2022

Warning: iconv(): Wrong encoding, conversion from "UTF-8" to "UTF-8//IGNORE" is not allowed in /__w/php-src/php-src/ext/iconv/tests/bug48147.php

Consider to install libiconv-dev, if possible.

@mvorisek
Copy link
Contributor Author

mvorisek commented May 26, 2022

Warning: iconv(): Wrong encoding, conversion from "UTF-8" to "UTF-8//IGNORE" is not allowed in /__w/php-src/php-src/ext/iconv/tests/bug48147.php

Consider to install libiconv-dev, if possible.

gnu-libiconv-dev is already being installed and there is probably no other alternative iconv package - https://pkgs.alpinelinux.org/packages?name=*iconv*&branch=edge&arch=x86_64

@nikic
Copy link
Member

nikic commented May 26, 2022

Please don't mix the CI configuration for alpine and ubuntu -- at least as far as package installation and PHP configuration is concerned. This is going to be a big mess otherwise.

@cmb69
Copy link
Member

cmb69 commented May 26, 2022

gnu-libiconv-dev is already being installed […]

Then I suggest to verify that it is actually used; ICONV_IMPL and ICONV_VERSION or phpinfo() should yield the relevant info. Also, cat config.log after ./configure might generally be a good idea during testing this PR.

@cmb69
Copy link
Member

cmb69 commented Jul 25, 2022

the iconv tests look quite broken although the GNU iconv lib is installed:

But https://github.com/php/php-src/runs/7506541587?check_suite_focus=true#step:6:653:

checking if using GNU libiconv... no

@mvorisek
Copy link
Contributor Author

mvorisek commented Jul 25, 2022

the iconv tests look quite broken although the GNU iconv lib is installed:

But https://github.com/php/php-src/runs/7506541587?check_suite_focus=true#step:6:653:

checking if using GNU libiconv... no

thanks, I have found docker-library/php#1121 and docker-library/php#240

also related docker-library/php#1264 to the official images

@derickr
Copy link
Member

derickr commented Sep 28, 2023

I am closing this as the PR can't apply, nor does it address Nikita's comment wrt to splitting the actions to multiple files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants