Fix bug #61681: Malformed grammar #46
Merged
+247
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate T_STRING_VARNAME only if it actually is one. This is only the case
for "${varname}" and "${varname[offset]}" so we can just add a check for
} or [ after the LABEL.
php-pulls
pushed a commit
that referenced
this pull request
Apr 18, 2012
php-pulls
pushed a commit
that referenced
this pull request
Jan 17, 2014
php-pulls
pushed a commit
that referenced
this pull request
Jan 17, 2014
php-pulls
pushed a commit
that referenced
this pull request
Jan 17, 2014
moriyoshi
pushed a commit
to moriyoshi/php-src
that referenced
this pull request
Mar 15, 2014
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@319770 c90b9560-bf6c-de11-be94-00142212c4b1
php-pulls
pushed a commit
that referenced
this pull request
Jul 12, 2016
…ain names We don't actually fix this issue wrt. the empty $info array, because it is not clear what this array should contain and we're concerned about the potential BC break, but at least we fix the inconsistent handling of resulting domains with 255 bytes (which raise an error), and longer domains (which just return FALSE), what has to be considered a very minor BC break if at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://bugs.php.net/bug.php?id=61681.
After this writing "${func()}" is possible.