Try to fix macOS CI

[nielsdos]

No description provided.

[nielsdos]

Seems to work on first sight, it passes through configure at least.

[cmb69]

See PR #11056; in the meantime we dropped installing cURL from brew, but still add it to the pkg-config path. Maybe we should use Homebrew's cURL again; that might help to catch some issues with new cURL releases early. cc @iluuu1994

[nielsdos]

Ugh FFS, crash in CI is related to a bugfix that was apparently wrong but we don't have ASAN jobs in 8.2 to catch this (cfr #16736)
EDIT: ah it's a wrong merge, anyway, my point still stands
EDIT 2: fixed

[nielsdos]

Wait what, how is it failing now? It passed earlier...

[cmb69]

Wait what, how is it failing now? It passed earlier...

Yeah. It might be instable for whatever reasons. I suggest to brew reinstall curl instead of doing brew install openldap.

[cmb69]

macOS CI is green. Maybe run again to be "sure"?

[nielsdos]

OK, retriggering both macOS jobs.

[iluuu1994]

I don't understand why GitHub images change installed packages in "minor" versions... LGTM

[iluuu1994]

in the meantime we dropped installing cURL from brew

FWIU, curl was not actually installed from brew if it was already installed in the base image, which was likely added at some point. Forcing an installation through brew makes sense to me.

[nielsdos]

... And it failed on master ffs

[cmb69]

Ah: https://github.com/php/php-src/actions/runs/11757067559/job/32753899572#step:1:8 vs https://github.com/php/php-src/actions/runs/11756657260/job/32753493390#step:1:8. So depends on which version we get.

Anyhow, we may have the PKG_CONFIG_PATH backwards:

php-src/.github/actions/configure-macos/action.yml

Lines 14 to 20 in 89e750a

	export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:$BREW_OPT/[email protected]/lib/pkgconfig"
	export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:$BREW_OPT/curl/lib/pkgconfig"
	export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:$BREW_OPT/libffi/lib/pkgconfig"
	export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:$BREW_OPT/libxml2/lib/pkgconfig"
	export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:$BREW_OPT/libxslt/lib/pkgconfig"
	export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:$BREW_OPT/zlib/lib/pkgconfig"
	export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:$BREW_OPT/icu4c/lib/pkgconfig"

Should probably look first in BREW_OPT/… (aka preprend to PKG_CONFIG_PATH).

[nielsdos]

But why does the version even change?

[iluuu1994]

@nielsdos It's possible that GitHub doesn't roll out fresh images on all runners immediately.

[cmb69]

I'm currently trying #16741.

[cmb69]

That failed. But what is this

php-src/.github/actions/configure-macos/action.yml

Line 14 in 62e53e6

export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:$BREW_OPT/[email protected]/lib/pkgconfig"

Latest Homebrew wants OpenSSL 3.4.0 for curl and ldap. Is there any particular reason why we're still using OpenSSL 1.1 for macOS x64? Hmm, apparently we're not using Homebrew's openssl at all. However,

https://github.com/php/php-src/actions/runs/11757637074/job/32755128612#step:5:428

Is that the native macOS OpenSSL? I'm confused. Ah, thats >= 1.1

Well, let's try at #16741.

PS: actions/runner-images#10817
PPS: epic