Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for necessary move to macOS 13 #16469

Open
wants to merge 1 commit into
base: PHP-8.1
Choose a base branch
from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Oct 16, 2024

GH will remove macOS 12 runner images as of December 3rd, so we prepare for that.


https://app.github.media/e/es?s=88570519&e=3837111&elqTrackId=78D8A052C380BCBFF284D754BEBE9730&elq=f4dd0fae19804631a9520380d9a17f1f&elqaid=4233&elqat=1

Note that nightlies will affected by this, too, but maybe focus on the push workflows for now.

@cmb69
Copy link
Member Author

cmb69 commented Oct 16, 2024

GH will remove macOS 12 runner images as of December 3rd, so we prepare
for that.

Besides the obvious need to change the runner, we also suppress a
couple of warnings, because otherwise the build would fail due to
`-Werror`.
@cmb69 cmb69 marked this pull request as ready for review October 16, 2024 22:45
@cmb69
Copy link
Member Author

cmb69 commented Oct 17, 2024

By the way, why are we running debug builds on macOS (and one for Linux)? Wouldn't --enable-debug-assertions be sufficient (would probably need #16366)?

@arnaud-lb
Copy link
Member

Some benefits of --enable-debug-assertions over --enable-debug would be slightly faster tests (but slower build), more compiler diagnostics, and potentially more chance of finding release-only bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants