Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare zend_call_stack_size_error() as ZEND_API #16204

Closed
wants to merge 1 commit into from
Closed

Declare zend_call_stack_size_error() as ZEND_API #16204

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Oct 3, 2024

This is necessary at least on Windows to be able to actually call the function from a different module (in this case php8phpdbg.dll could not be build).

The zend_never_inline may no longer be necessary (or have any effect).

cc @arnaud-lb

@cmb69
Declare zend_call_stack_size_error() as ZEND_API
cb87971 
This is necessary at least on Windows to be able to actually call the
function from a different module (in this case php8phpdbg.dll could not
be build).
@cmb69 cmb69 requested a review from dstogov as a code owner October 3, 2024 17:41
devnexen referenced this pull request Oct 3, 2024
@arnaud-lb
Support stack limit in phpdbg SAPI
443aa29 
Fixes GH-16041
Closes GH-16055
arnaud-lb
arnaud-lb approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

zend_never_inline is still useful as it's called in the same translation unit (zend_vm_execute.h included in zend_execute.c).

@cmb69
Copy link
Member Author

cmb69 commented Oct 3, 2024

No ABI break; just an addition to fix Windows builds.

@cmb69 cmb69 removed the ABI break label Oct 3, 2024
@cmb69 cmb69 closed this in 6f7f32c Oct 3, 2024
@cmb69 cmb69 deleted the cmb/fix-phpdbg-build branch October 3, 2024 20:58
nielsdos added a commit to nielsdos/php-src that referenced this pull request Oct 4, 2024
@nielsdos
Use standard error message for stack limit in serialize()
22aa26d 
With phpGH-16204 merged, we can use the standard error message for the
recently-merged phpGH-16159.
@nielsdos nielsdos mentioned this pull request Oct 4, 2024
Closed
nielsdos added a commit that referenced this pull request Oct 4, 2024
@nielsdos
Use standard error message for stack limit in serialize()
612a6ad 
With GH-16204 merged, we can use the standard error message for the
recently-merged GH-16159.

Closes GH-16225.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmb69 @arnaud-lb