Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up on GH-15548: curl_multi_select. #15594

Closed
wants to merge 1 commit into from
Closed

Follow-up on GH-15548: curl_multi_select. #15594

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

throws a ValueError on timeout overflow.

@devnexen
Follow-up on phpGH-15548: curl_multi_select.
545276a 
throws a ValueError on timeout overflow.
@devnexen devnexen requested a review from adoy as a code owner August 27, 2024 04:09
@devnexen devnexen requested a review from Girgias August 27, 2024 05:22
Girgias
Girgias approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM, don't forget an UPGRADING entry

@Girgias
Copy link
Member

Girgias commented Aug 27, 2024

Ah CI is broken

@devnexen
Copy link
Member Author

Ah CI is broken

was just a temporary github action failure it seems.

@devnexen devnexen closed this in c4ae645 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees
No one assigned
Labels
Extension: curl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @Girgias