Fix GH-10232 autoload during constant resolution. #13313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranvis
force-pushed
the
const-ast-autoload
branch
from
243f8e1
to
2f7da9e
Compare
ranvis
changed the title
|
Updated the branch to propose a fix. |
ranvis
force-pushed
the
const-ast-autoload
branch
from
2f7da9e
to
73f87cf
Compare
|
Thank you @ranvis! I'll have a look on Monday. |
|
Bump on this, we are blocked by this bug for updating php version @iluuu1994 @dstogov |
dstogov
reviewed
Apr 22, 2024
There was a problem hiding this comment.
In my opinion, this looks right.
@iluuu1994 if you don't see any problems, please, merge this.
|
This slipped through on my side. I'll have a look today. |
|
Oops, I linked this PR in a wrong commit. Sorry about that. |
|
This change looked correct to me as well. Thank you @ranvis! And sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix and test for #10232.
The filename and line number are incorrect when userland code is executed during constant expression resolution, resulting in the failure of
includefunctions.https://3v4l.org/v4nl0