Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #74129: Incorrect SCRIPT_NAME with apache ProxyPassMatch when spaces are in path #10869

Closed
wants to merge 1 commit into from

Conversation

bukka
Copy link
Member

@bukka bukka commented Mar 17, 2023

As described in the pull request, this is caused by the fact that Apache URL decodes path info in the SCRIPT_NAME because it is required in CGI RFC.

@bukka bukka changed the base branch from master to PHP-8.1 March 17, 2023 14:59
@bukka bukka force-pushed the fpm_fcgi_envs_ap_pp_sn_strip_enc branch from b29b0c4 to f8a4e92 Compare March 17, 2023 14:59
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor type nits.

Can't really comment on the rest, but I'm expecting this works and is tested properly.

sapi/fpm/fpm/fpm_main.c Outdated Show resolved Hide resolved
sapi/fpm/fpm/fpm_main.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants