Skip to content

Commit

Permalink
Fix GH-13727: Building with -Werror=strict-prototypes (#14029)
Browse files Browse the repository at this point in the history
This is addon to the GH-13727 bug fix. When configuring the build with:

  ./configure CFLAGS=-Werror=strict-prototypes

libtool check for parsing nm command would fail:

  checking command to parse /usr/bin/nm -B output from cc object... failed

Upstream libtool has this specific check already fixed. Note that this
works only with Autoconf version 2.72 and later and is preparation for
future compilers that might have this error enabled by default.
  • Loading branch information
petk authored Apr 22, 2024
1 parent f8b9030 commit 44775b7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ PHP NEWS
. Fixed bug GH-14013 (Erroneous dnl appended in configure). (Peter Kokot)
. Fixed bug GH-10232 (If autoloading occurs during constant resolution
filename and lineno are identified incorrectly). (ranvis)
. Fixed bug GH-13727 (Missing void keyword). (Peter Kokot)

- Fibers:
. Fixed bug GH-13903 (ASAN false positive underflow when executing copy()).
Expand Down
2 changes: 1 addition & 1 deletion build/libtool.m4
Original file line number Diff line number Diff line change
Expand Up @@ -4636,7 +4636,7 @@ for ac_symprfx in "" "_"; do
extern "C" {
#endif
char nm_test_var;
void nm_test_func(){}
void nm_test_func(void){}
#ifdef __cplusplus
}
#endif
Expand Down

0 comments on commit 44775b7

Please sign in to comment.