Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOM_RET_OBJ calls for 8.4 #2

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

remicollet
Copy link
Member

@remicollet remicollet commented Sep 30, 2024

From UPGRADING.INTERNALS

   - Removed the `ret` argument from the DOM_RET_OBJ macro, use the return
     value instead.

Notice: was already using return_value by default (at least since 7.0), because of strange macro def.

#define DOM_RET_OBJ(obj, ret, domobject) \
	*ret = php_dom_create_object(obj, return_value, domobject)

@chschneider
Copy link

Are the reasons not to merge this request and release a PHP 8.4 compatible version? We're using xmldiff and would be happy to remove this 8.4 blocker :-)

@nielsdos
Copy link
Member

I pinged some people to get this merged.

@derickr derickr merged commit 6f39eda into php:master Nov 27, 2024
@derickr
Copy link
Member

derickr commented Nov 27, 2024

I've merged this, and released version 1.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants