Merge mqmh features with php 8.x support #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merges rstmpw/php7-mqmh, which brings some additional features, into php/master which supports building with php 8.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rstmpw/ibmmq php library relies on a set of features thats is - as far as I was able to tell - not available in the base version of this extension, but only in a fork provided by rstmpw.
I took the liberty of trying to merge both, the php8 related changes in this version with the "mqmh" stuff in their branch to create a version that support both building for php 8.x (we use 8.1) and works with the ibmmq php lib.
While the php library itself seem to be unmaintained, I think these features may be helpful either way.
The important thing here is "I think". I know we use this thing, but I have no understanding of its internals, nor do I know what this branch exactly adds. Seems to be some newer version of message handle in a newer release of the ibm lib?
So this is really just an desperate attempt to "make the thing do things". For now, it looks pretty good for our use case, but that may vary for others. Not sure.