-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use zend_str_tolower instead of php_strtolower
- Loading branch information
1 parent
03ecc34
commit 56c80d2
Showing
2 changed files
with
5 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56c80d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@remicollet I think you missed this one:
https://github.com/php/pecl-mail-mailparse/blob/v3.1.7/php_mailparse_rfc822.re#L294
(see for example https://github.com/mlocati/docker-php-extension-installer/actions/runs/11177749743/job/31073896101?pr=988)
56c80d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch
BTW, build should use the php_mailparse_rfc822.c, not the php_mailparse_rfc822.re (only when needed), which explain build passes for me on all the matrix (7.3 to 8.4)