escapeshellcmd: add warning about spaces in paths on Windows #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a known issue that spaces are not escaped in shell commands, which can be especially problematic on Windows. This adds a warning about this behaviour to the function, including a way to solve this in userland code. Ref: https://bugs.php.net/bug.php?id=43261 (last two comments) Also see: squizlabs/PHP_CodeSniffer#3214
jrfnl
force-pushed
the
feature/escapeshellcmd-add-warning-about-spaces-vs-windows
branch
from
ae677e1 to
1fc3c1e
Compare
|
Thank you! However, that wouldn't work if the complete command line is passed, would it? I think that needs clarification. |
|
@cmb69 Good point. I just tried with an arbitrary command I had been running anyway and Windows 10 seems to handle it fine:
Happy to run additional tests with more complex examples to be sure. Suggestions for commands to test are welcome. |
cmb69
approved these changes
Apr 5, 2021
jrfnl
deleted the
feature/escapeshellcmd-add-warning-about-spaces-vs-windows
branch
|
Thanks @cmb69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a known issue that spaces are not escaped in shell commands, which can be especially problematic on Windows.
This adds a warning about this behaviour to the function, including a way to solve this in userland code.
Ref: https://bugs.php.net/bug.php?id=43261 (last two comments)
Also see: squizlabs/PHP_CodeSniffer#3214