Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ReflectionGenerator::isClosed() #3896

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Document ReflectionGenerator::isClosed() #3896

merged 2 commits into from
Oct 22, 2024

Conversation

TimWolla
Copy link
Member

No description provided.

@TimWolla TimWolla requested a review from Girgias October 22, 2024 12:51
@TimWolla TimWolla mentioned this pull request Oct 22, 2024
Open
Girgias
Girgias approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor markup remarks

reference/reflection/reflectiongenerator/isclosed.xml Outdated Show resolved Hide resolved
reference/reflection/reflectiongenerator/isclosed.xml Outdated Show resolved Hide resolved
reference/reflection/reflectiongenerator/isclosed.xml Outdated Show resolved Hide resolved
@Girgias Girgias merged commit 84883b6 into php:master Oct 22, 2024
2 checks passed
@TimWolla TimWolla deleted the reflectiongenerator-isClosed branch October 22, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimWolla @cmb69 @Girgias