Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Invoice resource #140

Closed
wants to merge 9 commits into from
Closed

Conversation

iranl
Copy link
Contributor

@iranl iranl commented Apr 28, 2019

  • Adds listAll() function to Invoices
  • Adds results/messages to Invoices through BaseObject
  • Adds VAT lines
  • Adds UnitsPriceInc to Sales invoice lines (for Invoice types that include VAT)
  • Adds customerName, debitCredit and invoiceAmount variables which are returned when using listAll()
  • Changes looping through Sales invoice lines from:
$responseDOM->getElementsByTagName('line')

To:

$linesDOM->childNodes
  • Some formatting/order changes

Copy link
Contributor

@willemstuursma willemstuursma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I would like to use a bit more typing where appropriate. Would it be possible to add some new test cases?

src/Invoice.php Show resolved Hide resolved
src/Invoice.php Show resolved Hide resolved
src/Invoice.php Show resolved Hide resolved
src/InvoiceVatLine.php Show resolved Hide resolved
src/InvoiceVatLine.php Show resolved Hide resolved
src/InvoiceVatLine.php Show resolved Hide resolved
@iranl
Copy link
Contributor Author

iranl commented Apr 29, 2019

Thanks. I would like to use a bit more typing where appropriate. Would it be possible to add some new test cases?

Thanks for the review and requested changes, will get on them in the coming week.

@iranl
Copy link
Contributor Author

iranl commented May 9, 2019

Superseded by #142

@iranl iranl closed this May 9, 2019
@iranl iranl deleted the update-invoice branch June 30, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants