Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all symbolName logic into one method #244

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

IanDelMar
Copy link
Contributor

  • Merged symbolName logic from enterNode() and getNodeName() into getSymbolName() for improved readability and maintainability.
  • Added assertions to detect nodes without names, ensuring issues are caught early.
  • Renamed $fullSymbolName to $symbolName for consistency, as we only handle "full" symbol names.
  • Changed the fullSymbolName attribute to WPStubs_symbolName to minimize the risk of conflicts with existing attributes or potential overrides when extending this visitor, even though such issues are unlikely.

@szepeviktor
Copy link
Member

Too many bullet points!! 🙃

@szepeviktor szepeviktor merged commit e7d2598 into php-stubs:master Oct 3, 2024
5 checks passed
@IanDelMar IanDelMar deleted the symbolname branch October 9, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants