Add dynamic return type for stripslashes_from_strings_only #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds a class,
Faker
. This is a helper class for tests to "fake" types. Instead of$string_ = (string)$_GET['string']
, one can simply useFaker::type('string')
. This is particularly useful for types that cannot be cast. For example:can be simplified to
Faker::type('numeric-string')
as well. @szepeviktor, if you dislike this idea, I’ll revert to the traditional method. Otherwise, I would update all the other tests to use this class. Also, I’m flexible regarding the class name or method names. If there are other preferences, we can rename them.If we exclude the file from PHPStan analysis, we could even omit the method statements, as the type faking is handled through the docBlock. A new type can be introduced via the
@phpstan-type Types
.