Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React/Http to v0.8 #63

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Upgrade React/Http to v0.8 #63

merged 2 commits into from
Nov 21, 2017

Conversation

andig
Copy link
Contributor

@andig andig commented Oct 3, 2017

Supplements php-pm/php-pm#271

Points for follow-up:

  • remove minimum stability when react/http 0.8 has been released

@andig andig mentioned this pull request Oct 3, 2017
5 tasks
@dzubchik
Copy link
Contributor

dzubchik commented Nov 20, 2017

@andig , I would like to invest some time into stabilization http-kernel adapter and cover it with tests. Do you think it is right time for it? I plan to write tests for next things:

  • stateless requests
  • statefull requests
  • file uplodaing
  • file serving
  • etc

@andig
Copy link
Contributor Author

andig commented Nov 21, 2017

@dzubchik sounds great! Two points for consideration:

  • ppm already has some tests that use the kernel adapter- might make sense to start with these and not duplicate
  • I'd personally suggest to base new tests on this PR/ PSR7 as basis although it's not merged yet, so opinions might differ

@andig andig merged commit f211009 into php-pm:master Nov 21, 2017
@andig andig deleted the react-0.8 branch November 21, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants