Skip shebang sequence if it is the first line

php-parallel-lint · Mar 27, 2024 · 3195a74 · 3195a74
1 parent b5c0080
commit 3195a74
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/bin/skip-linting.php b/bin/skip-linting.php
@@ -9,6 +9,12 @@
     $f = @fopen($file, 'r');
     if ($f) {
         $firstLine = fgets($f);
+
+        // ignore shebang line
+        if (strpos($firstLine, '#!') === 0) {
+            $firstLine = fgets($f);
+        }
+
         @fclose($f);
 
         if (preg_match('~<?php\\s*\\/\\/\s*lint\s*([^\d\s]+)\s*([^\s]+)\s*~i', $firstLine, $m)) {

diff --git a/tests/Unit/ParallelLintLintTest.php b/tests/Unit/ParallelLintLintTest.php
@@ -78,6 +78,16 @@ public function testValidFile()
         $this->assertSame(0, count($result->getErrors()));
     }
 
+    public function testSkipShebang()
+    {
+        $parallelLint = new ParallelLint($this->getPhpExecutable());
+        $result = $parallelLint->lint(array(PL_TESTROOT . '/fixtures/fixture-07/example.php'));
+
+        $this->assertSame(0, $result->getCheckedFilesCount());
+        $this->assertSame(0, $result->getFilesWithSyntaxErrorCount());
+        $this->assertSame(1, $result->getSkippedFilesCount());
+    }
+
     public function testInvalidFile()
     {
         $parallelLint = new ParallelLint($this->getPhpExecutable());

diff --git a/tests/fixtures/fixture-07/example.php b/tests/fixtures/fixture-07/example.php
@@ -0,0 +1,5 @@
+#!/usr/bin/php
+<?php // lint < 5.3
+
+$myString = 'This is always skipped';
+echo $myString;