Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfr] Map network fields #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haphan
Copy link
Collaborator

@haphan haphan commented Jun 9, 2016

@jamiehannaford
Copy link
Contributor

Aren't these values provided by the layer-3 and provider extensions?

@haphan
Copy link
Collaborator Author

haphan commented Jun 17, 2016

@jamiehannaford these values are retrievable via /v2.0/networks, why not also map them to Network model?

Besides, what is the general strategy for sdk to cover extensions?

@jamiehannaford
Copy link
Contributor

@haphan All extensions code should live under the extensions dir for that service, for example here. I wanted to do this so that we don't make any assumptions about users using a specific extension and mixing that code with the core service.

Even if the extension modifies a core URL endpoint (e.g. /networks) I still think we should separate but could have the extension resource class (ExtNetwork) extend the core resource (Network). We could even use the core Api and Params classes if the operations are identical, but at least we'd have separation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants