-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to override catalog URL, fix #341 #342
base: master
Are you sure you want to change the base?
Conversation
The python implementation allows overrides to happen at the Swift client level. What do you think if we can learn from that pattern to avoid coupling Identity service with the S3 client? |
I'm sorry, which coupling are you referring to? In this PR the endpoint URL override has been made very generic (probably much much more than what need in real-world scenario that would mostly apply to swift and cross-project application credentials or, at best, cross-project ACL). It's good because, well, it's generic (and, as such, does not touch swift-specifics or tight together different level of components) but may be seen as less obvious to configure than the straight |
Dears, I would be happy to see this in. |
Hello, Can you add some documentation and tests for this feature? |
Sadly not. I'm not currently working on this and can't find the time to dig into it again. |
@k0ka : Doc:
For example: catalog_overrides:
- name: swift
type: object-store
region: abc
interface: public
url: https://abc.com/v1/AUTH_123456 will override the |
fccbf8d
to
144a671
Compare
ping? |
This PR doesn't have tests and documentation so I can't accept it. I also don't understand its importance to do it by myself. |
Sample
$options
that can be passed toOpenstack\Openstack
(in YAML):