Left-pad large object segment names with zeros. #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The total length of the string is always 1 longer than the length of the string of the total number of segments. This way the segment name always starts with a 0 and there's no limit on the number of segments.
|
I can write a test for this. I would do it by modifying the create_large_object.php sample and updating the ObjectStore/v1/CoreTest's objects method. Do you want that added to this PR, or should it be separate? |
|
I put tests here for now: https://github.com/jbeales/openstack/tree/issue-318-tests The tests currently leave behind a container of segments. If I try to delete the segment container I get a HTTP 409. Maybe because it still has segments in it, (see #286). |
|
fixed in #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #318 by using a similar strategy as the official python command-line client. The segment name is left-padded with zeros so when the segment names are sorted on download they end up in the right order.
Instead of always using a length of 8 for the segment name like the command-line client, I checked the string length of the total number of segments, (which will be the name for the last segment), and added one. This way there's no client-imposed limit on the number of segments, at the expense of having to
sprintf()twice.